fix(tasks): prevent horizontal scroll in task view at narrow widths#2650
Draft
adboio wants to merge 1 commit into
Draft
fix(tasks): prevent horizontal scroll in task view at narrow widths#2650adboio wants to merge 1 commit into
adboio wants to merge 1 commit into
Conversation
The virtualized conversation/raw-log scroll container used `overflow-auto`, which enabled horizontal scrolling whenever a child was wider than the container. At narrow widths (e.g. the task view at 2/3 width on a 16" MBP) this made the whole pane scroll sideways. Switch to `overflow-y-auto overflow-x-hidden`. Wide content already manages its own horizontal scroll within bounded children (raw log entries use a per-entry `overflow-x-auto`, code blocks scroll internally), so the outer virtualized container never needs to scroll horizontally. Generated-By: PostHog Code Task-Id: c71dfd67-8c74-489f-bbcd-904bb94d3584
|
React Doctor could not complete this scan.
Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(tasks): prevent horizontal scroll in..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On smaller window widths (e.g. the task view at 2/3 width on a 16" MacBook Pro) the task view scrolled horizontally, which should never happen.
Changes
The virtualized conversation/raw-log scroll container used
overflow-auto, which enables both horizontal and vertical scrolling. Any child wider than the container (a long unwrapped line, a wide tool output) made the whole pane scroll sideways at narrow widths.Switched it to
overflow-y-auto overflow-x-hidden. Wide content already manages its own horizontal scroll within bounded children — raw log entries use a per-entryoverflow-x-autoand code blocks scroll internally — so the outer virtualized container never needs to scroll horizontally.How did you test this?
Did not run the app. Change is a one-line Tailwind class swap on the virtualized list scroll container, verified by tracing the layout: both consumers (conversation messages, raw logs) handle horizontal overflow within their own bounded children.
Automatic notifications
Created with PostHog Code from a Slack thread